Skip to content

Conversation

nscyclone
Copy link
Contributor

@nscyclone nscyclone commented Nov 21, 2017

This PR introduces another icon just below the menu hamburger to switch between the day and night modes. Closes #558.

Example:

night-mode

@josevalim
Copy link
Member

Thank you! Is it possible to have the icon in the same color as the hamburger icon?

/cc @dignifiedquire

@nscyclone
Copy link
Contributor Author

Thanks, @josevalim! I'm afraid we can't switch the color of the emoji versions, but we can use the text ones instead. There is an example pen, we could make use of the two glyphs on the left.

Let's wait for a review from @dignifiedquire.

@aphillipo
Copy link
Contributor

aphillipo commented Nov 21, 2017

I think the icons would be better as:

light -> 🌚 dark -> 🌝

I hate the sun emoji and crescent personally and find them a bit garish and out of place. You might find the same about these of course!

I'd also want to make sure that each of these has a 68x68px clickable area on mobile as it can e difficult to click anything smaller...

@josevalim
Copy link
Member

Should we use something from the icon font? Depending on emoji means we have no control over its exhibition.

@OvermindDL1
Copy link

Should we use something from the icon font?

If an icon font is available then that should be used, otherwise I'd just use inline svg (could even have some css animate the transition between both forms). Simple CSS needed, no javascript at all needed, and only static svg description in the html (the 'shape' is defined in CSS).

@josevalim
Copy link
Member

AFAIK, we already have an icon font.

@nscyclone
Copy link
Contributor Author

Yes, we have an icon font. It can easily be imported back into icomoon app to append a couple more icons from free packs.

It could look something like this:

updated-font

The original issue used a Twitter poll to get some feedback. Maybe we should choose a couple of options and make a new poll to let community decide?

@josevalim
Copy link
Member

The icon ones look a thousand times better to me so I would go ahead with them unless someone strongly opposes. :)

@dignifiedquire
Copy link
Contributor

agree with @josevalim thank you :)

@nscyclone
Copy link
Contributor Author

Huge thanks to everyone for all of your input. I've just updated the branch with icons from a recent comment.

The updated version now looks like this:

night-mode-with-icons

Looking forward to receive some feedback on this.

@josevalim
Copy link
Member

@nscyclone beautiful. One final question: should we remove the link at the bottom of the pages now?

@nscyclone
Copy link
Contributor Author

@josevalim I've already removed it.

@josevalim josevalim merged commit 80f31a9 into elixir-lang:master Nov 23, 2017
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@nscyclone nscyclone deleted the feature/558 branch November 23, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants